[da-vinci][controller] Filter out status reporting from the nodes, where the DaVinci app is still bootstrapping #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixGV
previously approved these changes
Sep 27, 2024
FelixGV
reviewed
Sep 27, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java
Outdated
Show resolved
Hide resolved
sixpluszero
reviewed
Sep 27, 2024
...nci-client/src/main/java/com/linkedin/davinci/kafka/consumer/KafkaStoreIngestionService.java
Show resolved
Hide resolved
gaojieliu
changed the title
sixpluszero
reviewed
Sep 30, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/VersionBackend.java
Show resolved
Hide resolved
gaojieliu
changed the title
gaojieliu
changed the title
…otstrapping In Prod, we are seeing the bootstrapping nodes are blocking the new push, and this PR disables the status reporting if the app is still bootstrapping. This feature is especially important for DaVinci apps, which are using multiple large stores and bootstrapping from an empty state can take a long time and it can delay the new push significantly.
1. Subscription won't return if there are still active current version bootstrapping to avoid serving stale current version. 2. Delete the heartbeat entry for the current instance if the instance is bootstrapping to avoid Controller mark the bootstrapping node as crashed, which can fail the new push jobs.
…at Controller can ignore the report
gaojieliu
force-pushed
the
bootstrapping_dvc_not_report_new_version_status
branch
from
57e2d9d
to
4750def
Compare
sixpluszero
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Prod, we are seeing the bootstrapping nodes are blocking the new push, and this PR will let Controller ignore the status report from the nodes, which are still bootstrapping.
This feature is especially important for DaVinci apps, which are using multiple large stores and bootstrapping from an empty state can take a long time and it can delay the new push significantly.
How was this PR tested?
Does this PR introduce any user-facing changes?