[da-vinci][controller] Add check to ensure version is valid before ingestion #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (getStore(clusterName, storeName).isDaVinciPushStatusStoreEnabled()) { | ||
| Set<Map.Entry<String, Integer>> versionSet = getCurrentVersionsForMultiColos( | ||
| clusterName, | ||
| SystemStore.SYSTEM_STORE_NAME_PREFIX + VeniceSystemStoreUtils.DAVINCI_PUSH_STATUS_STORE_STR + "_" + storeName) |
There was a problem hiding this comment.
nit: This can be replaced by VeniceSystemStoreType.getSystemStoreName(storeName)
|
Based on the original issue, we still only add a check here as opposed to trying to create one if it doesn't exist? The issue also suggests to try to create one if not exists and then fail if the creation fails. Do we plan to add that in subsequent PRs? If so, I 'd clarify the description to specify it partially resolves the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
Add check to ensure version is valid before ingestion
Resolves #657
How was this PR tested?
Ran "./gradlew check --continue"
Does this PR introduce any user-facing changes?