Updated StorageService constructor and initializer [modified]

linkedin · Sep 27, 2024 · 06dd6c2 · 06dd6c2
1 parent 6c50513
commit 06dd6c2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/...java/com/linkedin/davinci/consumer/InternalLocalBootstrappingVeniceChangelogConsumer.java b/...java/com/linkedin/davinci/consumer/InternalLocalBootstrappingVeniceChangelogConsumer.java
@@ -131,7 +131,7 @@ public InternalLocalBootstrappingVeniceChangelogConsumer(
         true,
         true,
         functionToCheckWhetherStorageEngineShouldBeKeptOrNot(),
-        functionToCheckWhetherStoragePartitionShouldBeKeptOrNot());
+        functionToCheckWhetherStoragePartitionsShouldBeKeptOrNot());
     storageMetadataService =
         new StorageEngineMetadataService(storageService.getStorageEngineRepository(), partitionStateSerializer);
   }
@@ -177,7 +177,7 @@ private Function<String, Boolean> functionToCheckWhetherStorageEngineShouldBeKep
     };
   }
 
-  private Function<AbstractStorageEngine, Void> functionToCheckWhetherStoragePartitionShouldBeKeptOrNot() {
+  private Function<AbstractStorageEngine, Void> functionToCheckWhetherStoragePartitionsShouldBeKeptOrNot() {
     return storageEngine -> null;
   }
 

diff --git a/clients/da-vinci-client/src/main/java/com/linkedin/davinci/storage/StorageService.java b/clients/da-vinci-client/src/main/java/com/linkedin/davinci/storage/StorageService.java
@@ -77,7 +77,7 @@ public class StorageService extends AbstractVeniceService {
    * @param restoreDataPartitions indicates if store data needs to be restored.
    * @param restoreMetadataPartitions indicates if meta data needs to be restored.
    * @param checkWhetherStorageEngineShouldBeKeptOrNot check whether the local storage engine should be kept or not.
-   * @param checkWhetherStoragePartitionShouldBeKeptOrNot check whether the partition is assigned and thus should be kept or not.
+   * @param checkWhetherStoragePartitionsShouldBeKeptOrNot check whether the partition is assigned and thus should be kept or not.
    */
   StorageService(
       VeniceConfigLoader configLoader,
@@ -89,7 +89,7 @@ public class StorageService extends AbstractVeniceService {
       boolean restoreDataPartitions,
       boolean restoreMetadataPartitions,
       Function<String, Boolean> checkWhetherStorageEngineShouldBeKeptOrNot,
-      Function<AbstractStorageEngine, Void> checkWhetherStoragePartitionShouldBeKeptOrNot,
+      Function<AbstractStorageEngine, Void> checkWhetherStoragePartitionsShouldBeKeptOrNot,
       Optional<Map<PersistenceType, StorageEngineFactory>> persistenceTypeToStorageEngineFactoryMapOptional) {
     String dataPath = configLoader.getVeniceServerConfig().getDataBasePath();
     if (!Utils.directoryExists(dataPath)) {
@@ -125,7 +125,7 @@ public class StorageService extends AbstractVeniceService {
           restoreDataPartitions,
           restoreMetadataPartitions,
           checkWhetherStorageEngineShouldBeKeptOrNot,
-          checkWhetherStoragePartitionShouldBeKeptOrNot);
+          checkWhetherStoragePartitionsShouldBeKeptOrNot);
     }
   }
 
@@ -139,7 +139,7 @@ public StorageService(
       boolean restoreDataPartitions,
       boolean restoreMetadataPartitions,
       Function<String, Boolean> checkWhetherStorageEngineShouldBeKeptOrNot,
-      Function<AbstractStorageEngine, Void> checkWhetherStoragePartitionShouldBeKeptOrNot) {
+      Function<AbstractStorageEngine, Void> checkWhetherStoragePartitionsShouldBeKeptOrNot) {
     this(
         configLoader,
         storageEngineStats,
@@ -150,7 +150,7 @@ public StorageService(
         restoreDataPartitions,
         restoreMetadataPartitions,
         checkWhetherStorageEngineShouldBeKeptOrNot,
-        checkWhetherStoragePartitionShouldBeKeptOrNot,
+        checkWhetherStoragePartitionsShouldBeKeptOrNot,
         Optional.empty());
   }
 

diff --git a/services/venice-server/src/main/java/com/linkedin/venice/server/VeniceServer.java b/services/venice-server/src/main/java/com/linkedin/venice/server/VeniceServer.java
@@ -332,7 +332,7 @@ private List<AbstractVeniceService> createServices() {
         whetherToRestoreDataPartitions,
         true,
         functionToCheckWhetherStorageEngineShouldBeKeptOrNot(),
-        functionToCheckWhetherStoragePartitionShouldBeKeptOrNot());
+        functionToCheckWhetherStoragePartitionsShouldBeKeptOrNot());
     storageEngineMetadataService =
         new StorageEngineMetadataService(storageService.getStorageEngineRepository(), partitionStateSerializer);
     services.add(storageEngineMetadataService);
@@ -715,7 +715,7 @@ private Function<String, Boolean> functionToCheckWhetherStorageEngineShouldBeKep
     return storageEngineName -> true;
   }
 
-  private Function<AbstractStorageEngine, Void> functionToCheckWhetherStoragePartitionShouldBeKeptOrNot() {
+  private Function<AbstractStorageEngine, Void> functionToCheckWhetherStoragePartitionsShouldBeKeptOrNot() {
     return storageEngine -> {
       String storageEngineName = storageEngine.toString();
       String storeName = Version.parseStoreFromKafkaTopicName(storageEngineName);