(feat) Allow sending of only aspect-specific audit events. #141
Conversation
We add an `emitGeneralAuditEvents` field to BaseLocalDAO which enables the sending of the general all-aspect audit events to be disabled, assuming that aspect-specific events are enabled.
| /** | ||
| * Enables or disables the emission of general audit events. | ||
| */ | ||
| public void enableGeneralAuditEvent(boolean generalAuditEventEnabled) { |
There was a problem hiding this comment.
why is this method public? If it's public then what is the difference between this method and setEmitGeneralAuditEvent ?
There was a problem hiding this comment.
No difference :) I was trying to be consistent in the naming and it turned out it wasn't possible--there's enableModelValidationOnWrite, but setEmitAspectSpecificAuditEvent. I thought enableGeneralAuditEvent was the "better" name, but added the other for symmetry with setEmitAspectSpecificAuditEvent. I can delete one or the other or, if you think enableFoo is the way forward, mark the setFoo one as deprecated and note that it just routes to enableFoo.
There was a problem hiding this comment.
Let's just stick with one method, enableGeneralAuditEvent sounds good to me.
We add an
emitGeneralAuditEventsfield to BaseLocalDAO which enablesthe sending of the general all-aspect audit events to be disabled,
assuming that aspect-specific events are enabled.
Checklist