Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Embedded Zookeeper listen on 127.0.0.1 #2196

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Set Embedded Zookeeper listen on 127.0.0.1 #2196

merged 1 commit into from
Sep 20, 2024

Conversation

akatona84
Copy link
Contributor

Summary

  1. Why: when on VPN, I can't run Cruise Control tests as ZK is binding to local real ip address and local network is restricted.
  2. What: changing to bind to 127.0.0.1 fixes it (got the idea from Kafka embedded ZK setup. I think it won't make any difference how automation or human would run the tests, pls correct me if I'm wrong.

Categorization

  • bugfix
  • new feature
  • refactor
  • CVE
  • other

mhratson
mhratson approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mhratson mhratson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Not expecting this to be a problem since it's a testing instance that shouldn't be accessed from anywhere else but tests.

@mhratson mhratson merged commit e3d718d into linkedin:main Sep 20, 2024
7 checks passed
@akatona84 akatona84 deleted the zk-test-listener branch September 23, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhratson mhratson mhratson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akatona84 @mhratson