Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce coupling to argparse, and separate Endpoint definitions from the provided parameters. #2021

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Reduce coupling to argparse, and separate Endpoint definitions from the provided parameters. #2021

wants to merge 27 commits into from

Commits on May 23, 2023

  1. Setting up initial function definitions.

    @twcurrie
    twcurrie committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ff59eaf View commit details
    Browse the repository at this point in the history

  2. Pulling out first function.

    @twcurrie
    twcurrie committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7b8a04f View commit details
    Browse the repository at this point in the history

  3. Adding initial tests.

    @twcurrie
    twcurrie committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ec4eb09 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Pulling out handling of modifications, providing test.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d42b534 View commit details
    Browse the repository at this point in the history

  2. Updating comments.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7ec6cde View commit details
    Browse the repository at this point in the history

  3. Constructing lengthy test to trigger exception.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b52a1ea View commit details
    Browse the repository at this point in the history

  4. Adding a container for parameters.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7dc0ec0 View commit details
    Browse the repository at this point in the history

  5. Adding boolean flag to indicate broker id requirement.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    34e47c2 View commit details
    Browse the repository at this point in the history

  6. Extending parameter set

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    829d555 View commit details
    Browse the repository at this point in the history

  7. Shifting away from class=based ExecutionContext

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6df3cbe View commit details
    Browse the repository at this point in the history

  8. Adding some tests around ParameterSet

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    389dfe2 View commit details
    Browse the repository at this point in the history

  9. Pushing default to parameter definition, rather than __init__

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    18d9c23 View commit details
    Browse the repository at this point in the history

  10. Pivoting endpoint to not hold parameters.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    4df2177 View commit details
    Browse the repository at this point in the history

  11. Removing difference between parameter name and request flag.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    74f7c1d View commit details
    Browse the repository at this point in the history

  12. Removing parameter checks, relying on default rather than __init__ de… 

    …clarations.
    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9a6ec4d View commit details
    Browse the repository at this point in the history

  13. Correcting argument check.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d294c4f View commit details
    Browse the repository at this point in the history

  14. Modifying test.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c604ced View commit details
    Browse the repository at this point in the history

  15. Reorder class methods.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8e1e68b View commit details
    Browse the repository at this point in the history

  16. Updating comments.

    @twcurrie
    twcurrie committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7e64ce3 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Reversing broker id switch

    @twcurrie
    twcurrie committed May 25, 2023
    Configuration menu
    Copy the full SHA
    f443566 View commit details
    Browse the repository at this point in the history

  2. Providing argument name alignment.

    @twcurrie
    twcurrie committed May 25, 2023
    Configuration menu
    Copy the full SHA
    630aa14 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/migrate_to_kafka_2_5' into argparse 

    # Conflicts:
#	.gitignore
    @twcurrie
    twcurrie committed May 25, 2023
    Configuration menu
    Copy the full SHA
    4b6efcc View commit details
    Browse the repository at this point in the history

  4. Removing redundant class variable.

    @twcurrie
    twcurrie committed May 25, 2023
    Configuration menu
    Copy the full SHA
    d6c3294 View commit details
    Browse the repository at this point in the history

  5. Shifting more logic from endpoint to parameter set.

    @twcurrie
    twcurrie committed May 25, 2023
    Configuration menu
    Copy the full SHA
    15ecbeb View commit details
    Browse the repository at this point in the history

  6. Adding back the deprecated function, maybe a bit much.

    @twcurrie
    twcurrie committed May 25, 2023
    Configuration menu
    Copy the full SHA
    558667c View commit details
    Browse the repository at this point in the history

  7. Updating function names.

    @twcurrie
    twcurrie committed May 25, 2023
    Configuration menu
    Copy the full SHA
    bcd8d46 View commit details
    Browse the repository at this point in the history

  8. UPdating docs.

    @twcurrie
    twcurrie committed May 25, 2023
    Configuration menu
    Copy the full SHA
    9c6b512 View commit details
    Browse the repository at this point in the history