Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid offer_hash PaymentId collision #132

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Avoid offer_hash PaymentId collision #132

merged 2 commits into from
Mar 9, 2024

Commits on Mar 8, 2024

  1. Generate random PaymentId for outbound offers 

    Previously, we'd deterministically derive the `offer_hash` as a
`PaymentId` for outbound BOLT 12 payments. However, as offers may be
paid multiple times, this could result in collisions in our
`outbound_payments` store.

Here, we therefore use random `PaymentId`s to avoid collisions, even if
offers are paid multiple times.
    @tnull
    tnull committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4a1a645 View commit details
    Browse the repository at this point in the history

  2. Fix warning by including error in error prompt

    @tnull
    tnull committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    f58bb84 View commit details
    Browse the repository at this point in the history