Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded Target enum #119

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Remove unneeded Target enum #119

merged 1 commit into from
Sep 21, 2023

Conversation

benthecarman
Copy link
Contributor

Think this existed because ConfirmationTarget didn't implement Hash but now it does. Can simplify the fees code from this

TheBlueMatt
TheBlueMatt reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But rustc (and then, I assume, rustfmt) is sad.

src/bitcoind_client.rs Outdated Show resolved Hide resolved
@tnull tnull merged commit 492de4e into lightningdevkit:main Sep 21, 2023
4 checks passed
@benthecarman benthecarman deleted the rm-targe branch September 21, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt left review comments

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benthecarman @tnull @TheBlueMatt