Merge pull request #6 from kinglozzer/fixes

Fix dialog button not displaying correctly
lekoala · Mar 3, 2022 · 7a75f02 · 7a75f02
2 parents 8b71f90 + 2a52172
commit 7a75f02
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/PureModalAction.php b/src/PureModalAction.php
@@ -83,7 +83,7 @@ protected function getButtonTitle()
      */
     protected function getDialogButtonTitle()
     {
-        $title = $this->buttonTitle ?: $this->title;
+        $title = $this->dialogButtonTitle ?: $this->title;
         if ($this->buttonIcon) {
             $title = '<span class="font-icon-' . $this->buttonIcon . '"></span> ' . $title;
         }
@@ -97,7 +97,7 @@ protected function getDialogButtonTitle()
      */
     public function setDialogButtonTitle($value)
     {
-        $this->buttonTitle = $value;
+        $this->dialogButtonTitle = $value;
         return $this;
     }
 

diff --git a/templates/LeKoala/PureModal/PureModalAction.ss b/templates/LeKoala/PureModal/PureModalAction.ss
@@ -21,7 +21,9 @@
             </div>
             <% if $ShowDialogButton %>
                 <div class="toolbar toolbar--south">
-                    <input type="submit" name="action_$Name" class="btn action btn btn-info custom-action" value="$ButtonTitle">
+                    <button type="submit" name="action_$Name" class="action custom-action<% if $extraClass %> $extraClass<% end_if %>">
+                        {$DialogButtonTitle.RAW}
+                    </button>
                 </div>
             <% end_if %>
         </div>