Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redeploy ClimSim with only 50 workers, due to caching errors #38

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Redeploy ClimSim with only 50 workers, due to caching errors #38

merged 4 commits into from
Aug 2, 2023

Conversation

cisaacstern
Copy link
Contributor

See discussion in #36.

@cisaacstern
Copy link
Contributor Author

The test Dataflow jobs deployed from this PR were correctly assigned max_num_workers=50 (based on the label here).

Screen Shot 2023-08-01 at 7 09 19 PM

but I now realize that this label will not be discoverable (with the current implementation from #37) on push events... 🤔

@cisaacstern
Copy link
Contributor Author

Ok! The rewritten workflow logic successfully deployed the test jobs to dataflow with max_num_workers=50. I believe this logic should now work for push events as well, so going to merge this and hope we get the desired result (production runs of both recipes with only 50 workers each).

@cisaacstern cisaacstern merged commit 25ff6e5 into main Aug 2, 2023
3 checks passed
@cisaacstern cisaacstern deleted the note-climsim-ratelimit-issue branch August 2, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
max_num_workers:50 run:climsim-highres-mli run:climsim-highres-mlo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cisaacstern