Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test High-Res MIP #73

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Test High-Res MIP #73

merged 10 commits into from
Nov 28, 2023

Conversation

jbusecke
Copy link
Collaborator

@jbusecke jbusecke commented Nov 27, 2023

#72

@jbusecke
Copy link
Collaborator Author

Oh yes. I activated the 'full' dynamic chunking for the first time, and look at this beautiful test dataset @rsignell:

image

I am quite happy with this hehe.

@jbusecke
Copy link
Collaborator Author

Trying the other datasets now as PR versions (which only loads two timesteps), will then move the iids to the main iid list and merge. Onwards!

@jbusecke jbusecke marked this pull request as ready for review November 28, 2023 04:39
@jbusecke
Copy link
Collaborator Author

They all worked, yay. Lets get this on the road!

@jbusecke jbusecke merged commit 1410329 into main Nov 28, 2023
1 check passed
@rsignell
Copy link

rsignell commented Nov 28, 2023

Woohoo! I'm glad this worked! Is the final dataset going to be chunked 1 in time though?

@jbusecke
Copy link
Collaborator Author

No this is a downside of the pruning we do here...the dynamic chunking function only sees 2 files, and thus the final chunking will be different on the final product...

@rsignell
Copy link

rsignell commented Mar 20, 2024

@jbusecke where do we stand on this Hi-Res MIP dataset?
Did the non-pruned version get made available somewhere?

@jbusecke
Copy link
Collaborator Author

We were running into a pretty gnarly error that (in my intuition is caused by very large datasets with 'orthogonal' rechunking (going from time only to 'chunked all over the place') - read exactly these HighResMIP datasets). I am currently pushing hard on getting an MRE for this and hopefully that can serve as fuel to fix that bug upstream. Sorry for the delay again...

@rsignell
Copy link

Thanks for keeping this alive, @jbusecke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants