fix: can start multi times (#31)

layotto · Aug 24, 2023 · 2d1895a · 2d1895a
1 parent c32523b
commit 2d1895a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/server/Server.ts b/src/server/Server.ts
@@ -19,7 +19,6 @@ import { ServerCredentials, Server as GRPCServer } from '@grpc/grpc-js';
 import { AppCallbackService } from '../../proto/runtime/v1/appcallback_grpc_pb';
 import GRPCServerImpl from './GRPCServerImpl';
 import PubSub from './PubSub';
-import { sleep } from '../utils';
 
 const debug = debuglog('layotto:server:main');
 
@@ -35,6 +34,7 @@ export default class Server {
   protected readonly logger: Console;
   private readonly _serverImpl: GRPCServerImpl;
   private readonly _server: GRPCServer;
+  #start = false;
 
   constructor(port: string = process.env.appcallback_GRPC_PORT ?? '9999',
     GRPCServerInstance?: any,
@@ -54,9 +54,10 @@ export default class Server {
   }
 
   async start(): Promise<void> {
+    if (this.#start) return;
+    this.#start = true;
     await this._bind();
     this._server.start();
-    await sleep(250);
   }
 
   async close(): Promise<void> {

diff --git a/test/unit/server/GRPCServerImpl.test.ts b/test/unit/server/GRPCServerImpl.test.ts
@@ -65,6 +65,8 @@ describe.skip('server/GRPCServerImpl.test.ts', () => {
     const serverImpl = new CustomGRPCServerImpl(pubsubConfig);
     server = new Server('9999', serverImpl);
     await server.start();
+    // start multi times should work
+    await server.start();
   });
 
   afterAll(async () => {