Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Update LinkedInProvider.php #670

Merged
merged 6 commits into from
Oct 30, 2023
Merged

[5.x] Update LinkedInProvider.php #670

merged 6 commits into from
Oct 30, 2023

Conversation

moha-ep
Copy link
Contributor

@moha-ep moha-ep commented Oct 24, 2023

Add vanityName on query to get the "nickname"

Add vanityName on query
@driesvints driesvints marked this pull request as draft October 24, 2023 11:48
@driesvints
Copy link
Member

Can you fix the test suite please?

@driesvints driesvints changed the title Update LinkedInProvider.php [5.x] Update LinkedInProvider.php Oct 24, 2023
@driesvints driesvints changed the title [5.x] Update LinkedInProvider.php [5.x] Update LinkedInProvider.php Oct 24, 2023
@moha-ep
Copy link
Contributor Author

moha-ep commented Oct 30, 2023

Can you fix the test suite please?

I don't know why the tests are failing
My changes are based on the Linkedin documentation https://learn.microsoft.com/en-us/linkedin/shared/integrations/people/profile-api

@driesvints driesvints marked this pull request as ready for review October 30, 2023 13:43
@driesvints
Copy link
Member

I fixed these for you and will let @taylorotwell review now.

@moha-ep
Copy link
Contributor Author

moha-ep commented Oct 30, 2023

I fixed these for you and will let @taylorotwell review now.

That change you have made I already did last week, I just did not modify the tests, but thank you very much for the change waiting for the revision to be done
ClipWindowsGIF

@taylorotwell taylorotwell merged commit e7e4eaa into laravel:5.x Oct 30, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants