Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the api for getting emails as previous one not working for github provider #667

Closed
wants to merge 1 commit into from

Conversation

lmottasin
Copy link

When we are getting emails list with previous api for github. When we are getting by user
use Laravel\Socialite\Facades\Socialite;
$user = Socialite::driver('github')->userFromToken($token);
So, I checked the api call manually with valid token still not getting the email. Then in github docs find another api endpoint to get the public emails. So just changing the urls https://../user/emails to https://../user/public_emails it fixed the problem.

@taylorotwell
Copy link
Member

Need more community feedback here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants