Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content too long #106

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Add content too long #106

merged 5 commits into from
Mar 23, 2024

Conversation

eyurtsev
Copy link
Collaborator

Add content too long

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain-extract ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2024 0:58am

# Limit the number of chunks to process
# Limit the number of chunks to process
if len(extraction_requests) < settings.MAX_CHUNKS:
content_too_long = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks backwards

@@ -191,4 +199,7 @@ async def test_extract_from_large_file() -> None:
headers=headers,
)
assert response.status_code == 200
assert response.json() == {"data": ["a"]}
assert response.json() == {
"data": ["a", "b"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test should trigger content_too_long True

@eyurtsev eyurtsev merged commit d5231a4 into main Mar 23, 2024
11 checks passed
@eyurtsev eyurtsev deleted the eugene/add_content_too_long branch March 23, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants