driver/usbstoragedriver: use udisk2 only when calling write_file #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emantor
reviewed
Apr 9, 2024
| @@ -75,6 +80,8 @@ def write_files(self, sources, target, partition, target_is_directory=True): | |||
| target_is_directory (bool): Whether target is a directory | |||
| """ | |||
|
|
|||
| self._start_wrapper() | |||
There was a problem hiding this comment.
I think another if self.wrapper: is required here, otherwise we restart a new AgentWrapper for every write_files() call.
There was a problem hiding this comment.
I've added the check to _start_wrapper().
Otherwise, udisks2 and gi are needed for all installations, even if write_files is never used. Fixes: labgrid-project#1219 Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
jluebbe
force-pushed
the
fix-missing-udisks2-gi
branch
from
29f87d1
to
fbca8a0
Compare
|
that fixed it for us |
|
Sorry for the breakage! |
Emantor
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, udisks2 and gi are needed for all installations, even if write_files is never used.
Fixes: #1219