Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add KUBESPHERE_EDITION constants to globals config #4308

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

yazhouio
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2024
@yazhouio
Copy link
Member Author

Signed-off-by: yazhou <yazhouhu@yunify.com>
Signed-off-by: yazhou <yazhouhu@yunify.com>
@donniean
Copy link
Contributor

/lgtm

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 267a7047dd325fab3b8356e551b4a001f0aa972b

@ks-ci-bot ks-ci-bot merged commit 89430ef into kubesphere:master Sep 24, 2024
5 checks passed
Leioy pushed a commit to Leioy/console that referenced this pull request Sep 25, 2024
…4308) (#5197)

* feat: Add KUBESPHERE_EDITION constants to globals config



* refactor: Update KUBESPHERE_EDITION constants to globals config



---------

Signed-off-by: yazhou <yazhouhu@yunify.com>
Co-authored-by: 古月 <17949154+yazhouio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants