[release-1.7] 🌱 Add verify-govulncheck target and integrate to scan action #2215
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
|
/retest-required |
1 similar comment
|
/retest-required |
| fi | ||
|
|
||
| .PHONY: verify-flavors | ||
| verify-flavors: $(FLAVOR_DIR) generate-flavors ## Verify generated flavors |
There was a problem hiding this comment.
Looks like this is not part of the original cherry-pick.
@chrischdi Maybe for simplicity. Can you open PRs for all branches (including 1.8) to resync .github/workflows + the Makefile changes? (including the changes to the generate-flavors tool)
There was a problem hiding this comment.
Would that sync include the failed cherry-picks from #2167 ? Don't want to hit those twice
There was a problem hiding this comment.
Yup. Talked to Christian. He'll do a series of cherry-picks later today to bring GitHub actions, Makefile and related scripts in sync across 1.8-1.5 (also includes the IPClaim PR which will merge soon)
There was a problem hiding this comment.
SGTM - I'd just started looking at the failing cherry-picks, luckily I saw this too 😄
There was a problem hiding this comment.
Yup sorry missed writing this somewhere while debugging our CI env :)
|
/retest |
|
/hold for syncing stuff.. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/close In favor of #2226 |
|
@chrischdi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a manual cherry-pick of #2174