Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supports running as a DaemonSet #245

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat: supports running as a DaemonSet #245

merged 1 commit into from
Apr 25, 2024

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Apr 11, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
@chengxiangdong @niuzhenguo

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 11, 2024
chengxiangdong
chengxiangdong requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@chengxiangdong chengxiangdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring part of LeaderElection is more complicated, please simplify it.

docs/getting-started.md Outdated Show resolved Hide resolved
hack/deploy/huawei-cloud-controller-manager.yaml Outdated Show resolved Hide resolved
hack/pre-run-e2e.sh Outdated Show resolved Hide resolved
hack/pre-run-e2e.sh Outdated Show resolved Hide resolved
manifests/huawei-cloud-controller-manager-deployment.yaml Outdated Show resolved Hide resolved
pkg/cloudprovider/huaweicloud/huaweicloud.go Outdated Show resolved Hide resolved
@chengxiangdong
Copy link
Member

/assign

@chengxiangdong
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@chengxiangdong
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@chengxiangdong
Copy link
Member

/retitle feat: supports running as a DaemonSet

@k8s-ci-robot k8s-ci-robot changed the title feat(ds): transform deployment to daemonset feat: supports running as a DaemonSet Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 25, 2024
@chengxiangdong
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chengxiangdong, Zippo-Wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 40582ad into kubernetes-sigs:master Apr 25, 2024
6 checks passed
@Zippo-Wang Zippo-Wang deleted the feat_ds branch April 29, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiangdong chengxiangdong chengxiangdong requested changes

@niuzhenguo niuzhenguo Awaiting requested review from niuzhenguo

Assignees

@chengxiangdong chengxiangdong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zippo-Wang @chengxiangdong @k8s-ci-robot