Merge pull request #252 from chengxiangdong/fix_workflow

fix E2E workflow
kubernetes-sigs · Aug 20, 2024 · 0669a86 · 0669a86
2 parents d602479 + fdf3e20
commit 0669a86
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 15 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -70,7 +70,7 @@ jobs:
       - name: run e2e
         run: |
           export ARTIFACTS_PATH=${{ github.workspace }}/e2e-logs
-          sh hack/run-e2e.sh
+          ./hack/run-e2e.sh
       - name: upload logs
         if: always()
         uses: actions/upload-artifact@v3

diff --git a/hack/deploy/huawei-cloud-controller-manager.yaml b/hack/deploy/huawei-cloud-controller-manager.yaml
@@ -169,6 +169,8 @@ spec:
           effect: NoSchedule
         - key: node-role.kubernetes.io/control-plane
           effect: NoSchedule
+        - key: node-role.kubernetes.io/controlplane
+          effect: NoSchedule
       serviceAccountName: cloud-controller-manager
       containers:
         - name: huawei-cloud-controller-manager

diff --git a/hack/pre-run-e2e.sh b/hack/pre-run-e2e.sh
@@ -22,30 +22,33 @@ export REGISTRY_SERVER_ADDRESS=swr.ap-southeast-1.myhuaweicloud.com
 export REGISTRY=${REGISTRY_SERVER_ADDRESS}/cloud-native
 export VERSION=v$(echo $RANDOM | sha1sum |cut -c 1-5)
 
-echo -e "\nBuild images"
+echo -e "\n:::::: Check KUBECONFIG ::::::"
+echo "KUBECONFIG="$KUBECONFIG
+
+echo -e "\n:::::: Check cloud-config Secret ::::::"
+count=$(kubectl get -n kube-system secret | grep cloud-config | wc -l)
+if [[ "$count" -ne 1 ]]; then
+  echo ":::::: Please create the cloud-config secret."
+  exit 1
+fi
+
+echo -e "\n:::::: Build images ::::::"
 # todo: Maybe we need load the image to target cluster node.
 make image-huawei-cloud-controller-manager
 
 tmpPath=$(mktemp -d)
-is_containerd=`command -v containerd`
+is_containerd=$(command -v containerd)
 echo "is_containerd: ${is_containerd}"
 if [[ -x ${is_containerd} ]]; then
   docker save -o "${tmpPath}/huawei-cloud-controller-manager.tar" ${REGISTRY}/huawei-cloud-controller-manager:${VERSION}
   ctr -n=k8s.io i import ${tmpPath}/huawei-cloud-controller-manager.tar
   rm -rf ${tmpPath}/huawei-cloud-controller-manager.tar
 fi
 
-echo -e "\nCheck cloud-config secret"
-count=`kubectl get -n kube-system secret cloud-config | grep cloud-config | wc -l`
-if [[ "$count" -ne 1 ]]; then
-  echo "Please create the cloud-config secret."
-  exit 1
-fi
-
 # Remove the existing provider if it exists.
 kubectl delete -n kube-system deployment --ignore-not-found=true huawei-cloud-controller-manager
 
-echo -e "\nDeploy huawei-cloud-controller-manager"
+echo -e "\n:::::: Deploy huawei-cloud-controller-manager ::::::"
 
 REPO_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 image_url=${REGISTRY}/huawei-cloud-controller-manager:${VERSION}

diff --git a/hack/run-e2e.sh b/hack/run-e2e.sh
@@ -31,21 +31,21 @@ GOPATH=$(go env GOPATH | awk -F ':' '{print $1}')
 export PATH=$PATH:$GOPATH/bin
 
 # Pre run e2e for extra components
-echo -e "\nRun pre run e2e"
+echo -e "\n:::::: Run pre run e2e ::::::"
 "${REPO_ROOT}"/hack/pre-run-e2e.sh
 
 # Run e2e
-echo -e "\nRun e2e"
+echo -e "\n:::::: Run e2e ::::::"
 set +e
 ginkgo -v --race --trace --fail-fast -p --randomize-all ./test/e2e/
 TESTING_RESULT=$?
 
 # Collect logs
 kubectl logs deployment/huawei-cloud-controller-manager -n kube-system > ${ARTIFACTS_PATH}/huawei-cloud-controller-manager.log
-echo -e "\nCollected logs at ${ARTIFACTS_PATH}:"
+echo -e "\n:::::: Collected logs at ${ARTIFACTS_PATH}:"
 
 # Post run e2e for delete extra components
-echo -e "\nRun post run e2e"
+echo -e "\n:::::: Run post run e2e ::::::"
 "${REPO_ROOT}"/hack/post-run-e2e.sh
 
 exit $TESTING_RESULT