Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish all architectures. #581

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Mar 12, 2024

This removes the workaround #304 which is no longer necessary after #579.

Testing: make docker-push-all and examined resulting manifest for all expected architectures.

This removes the no longer necessary workaround:
kubernetes-sigs#304
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2024
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 12, 2024

/assign @Jefftree

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2024
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 12, 2024

/test pull-apiserver-network-proxy-docker-build-amd64-master
/test pull-apiserver-network-proxy-docker-build-arm64-master
/test pull-apiserver-network-proxy-make-lint-master
/test pull-apiserver-network-proxy-test-master

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have tested with make docker-push-all and it's working.

$ oras manifest fetch ghcr.io/liangyuanpeng/proxy-server:1fda8bb91e3fc2d7152979832bfffadd0ec6f996
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2814,
         "digest": "sha256:5e464959f4cfac8d6fbef43c29146390b6be94cb2d605c2055ed658e7ade3b7f",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2814,
         "digest": "sha256:97084006f421428c62b9fe9fd030424b0e5a9c665ecfbc14ac2c65dbcbe8767e",
         "platform": {
            "architecture": "arm",
            "os": "linux",
            "variant": "v7"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2814,
         "digest": "sha256:b303bd538ff270f79c0ebb1b11a768dbbacfd5b0f55230478f61624d95d3e5c3",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2814,
         "digest": "sha256:85893c888491e40e9994f9baa8f556008cc385025a46616bb3a309e078e20f6d",
         "platform": {
            "architecture": "ppc64le",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2814,
         "digest": "sha256:29569468aa504445e747df7ed794a8c718343139af07cbccb839e14392322bfe",
         "platform": {
            "architecture": "s390x",
            "os": "linux"
         }
      }
   ]
}
$ oras manifest fetch ghcr.io/liangyuanpeng/proxy-agent:1fda8bb91e3fc2d7152979832bfffadd0ec6f996
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2813,
         "digest": "sha256:e0ed35e15eaeacde6eef50c432c92a7d5daa0c691ce7e58ce548cb799c3ff46f",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2813,
         "digest": "sha256:aa18349d36990b1b20d2040370fa04036bc1b22c714e5576ae4bb51589d1a48a",
         "platform": {
            "architecture": "arm",
            "os": "linux",
            "variant": "v7"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2813,
         "digest": "sha256:f419a9cce50d9309160f54c695c73b28754953df824cfec018a83eae83e3f1e3",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2813,
         "digest": "sha256:e30e51380a54e6c2a5253dd3878cf16c566ba9b782455ca93450197eef310a87",
         "platform": {
            "architecture": "ppc64le",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2813,
         "digest": "sha256:1405fca1a66d2d6ede7320bc341b7b0a03fefd8dfbfa743d9e4e622b1a136e54",
         "platform": {
            "architecture": "s390x",
            "os": "linux"
         }
      }
   ]
}

@cheftako
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jkh52, liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6e29eba into kubernetes-sigs:master Mar 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants