Disable broken github workflow (e2e). #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
jkh52
force-pushed
the
github-workflows
branch
2 times, most recently
from
e02d19e
to
68afe57
Compare
jkh52
force-pushed
the
github-workflows
branch
from
68afe57
to
8c2e9c0
Compare
k8s-ci-robot
added
size/L
jkh52
changed the title
jkh52
changed the title
|
discussing this at the office hours today, think we should merge this for now until @aojea is able to fix the upstream problem. /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, jkh52 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github actions seem to have recently been activated, exposing this bug.
More errors from #553 were uncovered; I fixed a few obvious things, but decided to disable the bulk of the e2e action (to unblock other PRs).
EDIT: I saw #555 after opening this. Is that near ready to merge? @liangyuanpeng @tallclair