Adds consistency to how we refer to Kubecost v2.0+ #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2.0, v2.x, or v2.x.x.
srpomeroy
previously approved these changes
Aug 20, 2024
There was a problem hiding this comment.
This LGTM.
@chipzoller @kwombach12 @joe-terrible and input from you on how we should refer to versions?
|
It's more common to express this as simply "v2" when we mean major version 2 and all following minor versions. |
|
@chipzoller I'm ok with standardizing on |
|
Definitely don't block on me here though. |
chipzoller
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A
Proposed Changes
No longer references v2.0, v2.x, or v2.x.x. I'm open to standardizing on something that isn't
v2.0+as well.