feat: add test script for cli server #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
reviewed
Mar 11, 2024
| id: push-worker | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . |
There was a problem hiding this comment.
add load: true ref :https://docs.docker.com/build/ci/github-actions/export-docker/
Abirdcfly
reviewed
Mar 11, 2024
.github/workflows/cli_test.yaml
Outdated
| docker ps | ||
| - name: Run test script | ||
| run: | | ||
| sh -C tests/example_test.sh |
There was a problem hiding this comment.
It looks like the top part is similar to https://github.com/kubeagi/core-library/blob/main/.github/workflows/image_build_test.yml, so I guess you could just modify that file?
There was a problem hiding this comment.
I simply cp those into the test action yaml for sure. Could we merge all tests together or leave it here as we might need other tests that would be better executed seperately?
Abirdcfly
reviewed
Mar 12, 2024
Lanture1064
force-pushed
the
dev
branch
3 times, most recently
from
7f8de0b
to
9019056
Compare
bjwswang
reviewed
Mar 12, 2024
bjwswang
reviewed
Mar 12, 2024
.github/workflows/cli_test.yaml
Outdated
| PYTHON_INDEX_URL=${{ env.PYTHON_INDEX_URL }} | ||
| - name: Run Docker Container | ||
| run: | | ||
| docker run -d --name temp-container test-image |
There was a problem hiding this comment.
temp-container -> cli-container
Lanture1064
force-pushed
the
dev
branch
7 times, most recently
from
4accb05
to
8334d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #38
Special notes for your reviewer