Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit the csv file should trigger an update of knowledgebase #921

Closed
wants to merge 1 commit into from

Conversation

0xff-dev
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it

fix: edit the csv file should trigger an update of knowledgebase

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

@Abirdcfly
Copy link
Collaborator

Just a suggestion:

we can change the direct modification of the csv in the test to modifying the csv through the api to make sure the whole process is working correctly:

info "7.6 update qa.csv to make sure it can be embedding"
echo "newquestion,newanswer,,," >>pkg/documentloaders/testdata/qa.csv
mc cp pkg/documentloaders/testdata/qa.csv arcadiatest/${bucket}/dataset/dataset-playground/v1/qa.csv
mc tag set arcadiatest/${bucket}/dataset/dataset-playground/v1/qa.csv "object_type=QA"
sleep 3
kubectl annotate knowledgebase/knowledgebase-sample-pgvector -n arcadia "arcadia.kubeagi.k8s.com.cn/update-source-file-time=$(date)"

UpdateLines []CSVLine `json:"updateLines"`
NewLines [][]string `json:"newLines,omitempty"`
DelLines []int `json:"delLines"`
Knowledgebase string `json:"knowledgebase,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xff-dev There may have more than one knowledgebases which has this csv

@bjwswang
Copy link
Collaborator

@0xff-dev as discussed, please add verion in filegroup and update the version once edit succ

@bjwswang
Copy link
Collaborator

bjwswang commented Apr 7, 2024

@0xff-dev
Please remove the explicitly content check in modelscope_test.go

@0xff-dev 0xff-dev closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants