-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:find the permissions needed for the command gen_test_dataset #695
Conversation
@0xff-dev Is this good enough? Should we add the cluster role permissions ? 1.7067048284279842e+09 ERROR Reconciler error {"controller": "namespace", "controllerGroup": "", "controllerKind": "Namespace", "namespace": {"name":"kube-system"}, "namespace": "", "name": "kube-system", "reconcileID": "97dd6165-232f-492d-8b3a-76e8ace5441f", "error": "Operation cannot be fulfilled on clusterrolebindings.rbac.authorization.k8s.io \"ragas-eval-clusterrolebinding\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.2/pkg/internal/controller/controller.go:273
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.2/pkg/internal/controller/controller.go:234 |
The error reported here is from the controller, while trying to bind The controller's permissions to operate on clusterrolebiding have been updated in |
I also noticed that the controller report the warning some frequent:
@0xff-dev pls check why it's always conflict while binding serviceaccount to clusterrolebinding, can we try to avoid this? |
Seems we are trying to modify the same option 1: maintain a clusterrolebinding for each ns |
@xxxxibo Please rebase your branch |
What type of PR is this?
/kind bug
What this PR does / why we need it
Find the permissions needed for the command gen_test_dataset
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer