Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Salsa20 cipher and simplified ChaCha20 #717

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rogerxaic
Copy link

@rogerxaic rogerxaic commented Apr 16, 2019

Checklist:

  • Correct file headers (see CONTRIBUTING.md).
  • Formatted with SwiftFormat.
  • Tests passed.

Changes proposed in this pull request:

  • The Salsa20 algorithm has been added
  • The ChaCha20 algorithm implementation is simplified

@krzyzanowskim
Copy link
Owner

What is runtime performance difference?

@rogerxaic
Copy link
Author

rogerxaic commented Apr 16, 2019

I've got an average difference of 26ms on iOS and 35ms on Mac. Both quicker than the previous implementation.

@Sajjon
Copy link

Sajjon commented Apr 23, 2019

@rogerxaic By how many percent?

@rogerxaic
Copy link
Author

Between 2 and 3 percent if I recall correctly.

rogermiret-IBM and others added 7 commits April 27, 2019 12:31
# Conflicts:
#	Sources/CryptoSwift/ChaCha20.swift
Added Rotate left function which takes a value (a) to rotate and an amount (b) to rotate the value (a). The function returns the rotated (a).
@rogerxaic rogerxaic changed the title Simplified ChaCha20 algorithm implementation Added Salsa20 cipher and simplified ChaCha20 Apr 27, 2019
Repository owner deleted a comment Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants