Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix unsafe conversion in net_cls #2173

Merged

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

  • koordlet: Fix the unsafe conversion in the tc runtime hook plugin.

Ⅱ. Does this pull request fix one issue?

Resolve code scanning alerts #40, #41,

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (0fa719d) to head (9b35d88).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/koordlet/resourceexecutor/cgroup.go 0.00% 10 Missing ⚠️
pkg/koordlet/resourceexecutor/reader.go 0.00% 4 Missing ⚠️
pkg/koordlet/runtimehooks/hooks/tc/rule.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
- Coverage   67.90%   67.89%   -0.01%     
==========================================
  Files         443      443              
  Lines       41957    41967      +10     
==========================================
+ Hits        28490    28495       +5     
- Misses      11010    11018       +8     
+ Partials     2457     2454       -3     
Flag Coverage Δ
unittests 67.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 22, 2024
@koordinator-bot koordinator-bot bot merged commit e1d910a into koordinator-sh:main Aug 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants