Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: Add resctrl runtime hook for pod level #2123

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kangclzjc
Copy link
Member

Ⅰ. Describe what this PR does

Add resctrl runtime hook for pod level. It's part of the #1974.

Ⅱ. Does this pull request fix one issue?

#1831

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 28.90909% with 391 lines in your changes missing coverage. Please review.

Project coverage is 67.19%. Comparing base (0fa719d) to head (bca092b).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
pkg/koordlet/util/resctrl/resctrl.go 5.03% 151 Missing ⚠️
pkg/koordlet/runtimehooks/hooks/resctrl/resctrl.go 9.70% 91 Missing and 2 partials ⚠️
pkg/koordlet/util/resctrl/ctrl_mgr.go 61.05% 29 Missing and 8 partials ⚠️
pkg/koordlet/runtimehooks/protocol/pod_context.go 0.00% 31 Missing and 2 partials ⚠️
pkg/koordlet/runtimehooks/hooks/resctrl/updater.go 69.56% 24 Missing and 4 partials ⚠️
pkg/koordlet/runtimehooks/hooks/resctrl/rule.go 8.69% 21 Missing ⚠️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 45.83% 13 Missing ⚠️
pkg/koordlet/runtimehooks/protocol/protocol.go 0.00% 10 Missing ⚠️
...oordlet/runtimehooks/protocol/container_context.go 0.00% 2 Missing and 1 partial ⚠️
...et/qosmanager/plugins/resctrl/resctrl_reconcile.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
- Coverage   67.90%   67.19%   -0.71%     
==========================================
  Files         443      451       +8     
  Lines       41957    43242    +1285     
==========================================
+ Hits        28490    29058     +568     
- Misses      11010    11644     +634     
- Partials     2457     2540      +83     
Flag Coverage Δ
unittests 67.19% <28.90%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jasonliu747 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jasonliu747 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kangclzjc kangclzjc force-pushed the dev_pod_resctrl branch 2 times, most recently from 29fce55 to a9cec49 Compare August 28, 2024 07:07
@kangclzjc kangclzjc marked this pull request as ready for review August 28, 2024 07:37
pkg/koordlet/runtimehooks/hooks/resctrl/resctrl.go Outdated Show resolved Hide resolved
pkg/koordlet/util/resctrl/ctrl_mgr.go Outdated Show resolved Hide resolved
pkg/koordlet/util/resctrl/resctrl.go Outdated Show resolved Hide resolved
pkg/koordlet/util/resctrl/resctrl.go Outdated Show resolved Hide resolved
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
@kangclzjc
Copy link
Member Author

@saintube PTAL.

@saintube
Copy link
Member

/lgtm
PTAL /cc @zwzhang0107 @hormes

@koordinator-bot koordinator-bot bot merged commit b24da87 into koordinator-sh:main Sep 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants