Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 look for default rules provider in foundProviders #312

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

djzager
Copy link
Member

@djzager djzager commented Aug 7, 2024

No description provided.

Signed-off-by: David Zager <dzager@redhat.com>
@djzager djzager added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch. label Aug 7, 2024
@djzager djzager requested a review from eemcmullan August 7, 2024 13:22
@djzager
Copy link
Member Author

djzager commented Aug 7, 2024

lol. actually tested against a scenario that should work this time 🤦

windup-sample-apps/sample-binaries on  master
➜  ../../kantra/kantra analyze --overwrite --input ./jee-example-app-1.0.0.ear --output foo --source weblogic --target eap7
/opt/homebrew/bin/podman run --rm --name NVRVZjYICsFzXgSx --entrypoint /usr/local/bin/kantra --env RUN_MODE=container quay.io/konveyor/kantra:latest analyze --list-sources/opt/homebrew/bin/podman run --rm --name mtqbnFgCIhwBxxzU --entrypoint /usr/local/bin/kantra --env RUN_MODE=container quay.io/konveyor/kantra:latest analyze --list-targetsXffMylZzahRYbaWZ
xSfjspiLzVlurETj
INFO[0001] starting first provider                       provider=java
/opt/homebrew/bin/podman run -d --rm --name ocNVmWzattuQCQED --network XffMylZzahRYbaWZ -v xSfjspiLzVlurETj:/opt/input/source/jee-example-app-1.0.0.ear quay.io/konveyor/java-external-provider:latest --port=50507Trying to pull quay.io/konveyor/java-external-provider:latest...
Getting image source signatures
Copying blob sha256:7cdc457773a593882a976dd33db61179f62056ca2d69e3f9d3daee3b64482add
Copying blob sha256:44d42298f0986dde5bea2c0f2f4236eae0ab6bbc1f32de2d488a23fbecd40d8d
Copying blob sha256:0c52db48d6f4831ac8670c15a386b94f77127665bed4b0c9b1213682c0a5e977
Copying config sha256:19ae1c6bcda7eee9cb835ab372e457b1711270d10b60d6413ba8fd33e21d31ab
Writing manifest to image destination
aab0b19ec73f0da740b087f3029b3d54d4c452cb08e1521146bf5465366a755a
INFO[0008] running dependency retrieval during analysis
INFO[0008] running source code analysis                  args="--provider-settings=/opt/input/config/settings.json --output-file=/opt/output/output.yaml --context-lines=100 --rules=/opt/rulesets/ --verbose=4 --label-selector=((konveyor.io/target=eap7) && (konveyor.io/source=weblogic)) || (discovery) --dep-label-selector=(!konveyor.io/dep-source=open-source) --dep-output-file=/opt/output/dependencies.yaml" input=/Users/dzager/Workspace/windup-sample-apps/sample-binaries/jee-example-app-1.0.0.ear log=/Users/dzager/Workspace/windup-sample-apps/sample-binaries/foo/analysis.log output=/Users/dzager/Workspace/windup-sample-apps/sample-binaries/foo volumes="{\"/Users/dzager/Workspace/windup-sample-apps/sample-binaries/foo\":\"/opt/output\",\"/var/folders/rm/h4pf5h4j1z39vkywmhyfcgrh0000gn/T/analyze-config-2772959713\":\"/opt/input/config\",\"xSfjspiLzVlurETj\":\"/opt/input/source/jee-example-app-1.0.0.ear\"}"
INFO[0008] generating analysis log in file               file=/Users/dzager/Workspace/windup-sample-apps/sample-binaries/foo/analysis.log
/opt/homebrew/bin/podman run --rm --name ZeWzWhBClzVfiEDT --network container:ocNVmWzattuQCQED --entrypoint /usr/local/bin/konveyor-analyzer -v xSfjspiLzVlurETj:/opt/input/source/jee-example-app-1.0.0.ear -v /Users/dzager/Workspace/windup-sample-apps/sample-binaries/foo:/opt/output -v /var/folders/rm/h4pf5h4j1z39vkywmhyfcgrh0000gn/T/analyze-config-2772959713:/opt/input/config quay.io/konveyor/kantra:latest --provider-settings=/opt/input/config/settings.json --output-file=/opt/output/output.yaml --context-lines=100 --rules=/opt/rulesets/ --verbose=4 --label-selector=((konveyor.io/target=eap7) && (konveyor.io/source=weblogic)) || (discovery) --dep-label-selector=(!konveyor.io/dep-source=open-source) --dep-output-file=/opt/output/dependencies.yamlINFO[0070] generating static report                      args="/usr/local/bin/js-bundle-generator --output-path=/usr/local/static-report/output.js --analysis-output-list=/opt/output/output.yaml --application-name-list=jee-example-app-1.0.0.ear --deps-output-list=/opt/output/dependencies.yaml && cp -r /usr/local/static-report /opt/output" output=/Users/dzager/Workspace/windup-sample-apps/sample-binaries/foo
/opt/homebrew/bin/podman run --rm --name bpYVUTbGrcpevpcY --entrypoint /bin/sh -v /Users/dzager/Workspace/windup-sample-apps/sample-binaries/jee-example-app-1.0.0.ear:/opt/input/source/jee-example-app-1.0.0.ear/jee-example-app-1.0.0.ear -v /Users/dzager/Workspace/windup-sample-apps/sample-binaries/foo:/opt/output quay.io/konveyor/kantra:latest -c /usr/local/bin/js-bundle-generator --output-path=/usr/local/static-report/output.js --analysis-output-list=/opt/output/output.yaml --application-name-list=jee-example-app-1.0.0.ear --deps-output-list=/opt/output/dependencies.yaml && cp -r /usr/local/static-report /opt/outputINFO[0070] Static report created. Access it at this URL:  URL="file:///Users/dzager/Workspace/windup-sample-apps/sample-binaries/foo/static-report/index.html"

Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VISIACK, looks sane. Will let @eemcmullan take a look

@dymurray dymurray merged commit 766454b into konveyor:main Aug 7, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 7, 2024
Signed-off-by: David Zager <dzager@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
dymurray pushed a commit that referenced this pull request Aug 7, 2024
Signed-off-by: David Zager <dzager@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: David Zager <dzager@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants