✨ Add new command to run YAML tests #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
force-pushed
the
testRunner
branch
3 times, most recently
from
ca5cdec
to
bba8c38
Compare
pranavgaikwad
requested review from
shawn-hurley,
eemcmullan,
djzager,
jmle and
aufi
pranavgaikwad
force-pushed
the
testRunner
branch
4 times, most recently
from
8512eae
to
3b6e1e8
Compare
eemcmullan
reviewed
Mar 4, 2024
| logFile.Close() | ||
| continue | ||
| } | ||
| analysisParams := tests[0].TestCases[0].AnalysisParams |
There was a problem hiding this comment.
Something to future-proof if the spec changes?
There was a problem hiding this comment.
I wouldn't worry about this, if the spec changes, the whole logic of the runner will be affected, so we will have to handle that anyway.
shawn-hurley
approved these changes
Mar 13, 2024
| rulesSummary.passed += 1 | ||
| } | ||
| } | ||
| fmt.Fprintln(w, strings.Repeat("-", 60)) |
There was a problem hiding this comment.
I wonder if there is a utility to help output formatting like this?
pranavgaikwad
force-pushed
the
testRunner
branch
from
d5338f6
to
ffe8b34
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
force-pushed
the
testRunner
branch
2 times, most recently
from
657d07f
to
8963dbd
Compare
shawn-hurley
approved these changes
Mar 15, 2024
eemcmullan
approved these changes
Mar 15, 2024
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
force-pushed
the
testRunner
branch
from
8963dbd
to
2207b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testingthat defines APIs and implementations for writing and running YAML rules tests.I have tried to group commits to make it a little bit easier to review. See individual commit messages for details, let me know if you have any questions.