Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Fix api test runner; pr branch needs to be fetched. #175

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Sep 6, 2024

Fixes API tests not being run using the ${BRANCH}.

make[1]: Entering directory '/home/runner/work/tackle2-hub/tackle2-hub/go-konveyor-tests'
./hub-api/run-tests.sh refs/pull/635/merge
Cloning into '/tmp/tackle2-hub-test'...
fatal: 'origin/refs/pull/635/merge' is not a commit and a branch 'api-tests-run' cannot be created from it

PR branch needs to be fetched.

@jortel jortel added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch. label Sep 6, 2024
@jortel jortel requested a review from aufi September 6, 2024 19:32
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aufi
Copy link
Member

aufi commented Sep 9, 2024

@jortel TIER0 and TIER1 tests are green, merge as you need (TIER2 failure is not a blocker).

@jortel jortel merged commit 663ebce into konveyor:main Sep 9, 2024
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
* 👻 Fix api test runner; pr branch needs to be fetched.

Signed-off-by: Jeff Ortel <jortel@redhat.com>

* renamed.

Signed-off-by: Jeff Ortel <jortel@redhat.com>

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants