Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger on pull_request workflows on all branches #174

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

aufi
Copy link
Member

@aufi aufi commented Sep 6, 2024

There are TIER 0..2 on pull request workflows that should check the PR with CI. These workflows were targeted only to main branch that lead to not being executed on release-* branches. Updated to trigger on all branches.

Needs to be backported to release branches.

Fixes: #173

There are TIER 0..2 on pull request workflows that should check the PR
with CI. These workflows were targeted only to `main` branch that lead
to not being executed on release-* branches. Updated to trigger on all
branches.

Fixes: konveyor#173

Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi aufi requested a review from mguetta1 September 6, 2024 12:49
@aufi aufi added cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. cherry-pick/release-0.4 This PR should be cherry-picked to release-0.4 branch. cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch. labels Sep 6, 2024
Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aufi.
IIUC it will affect the badge status displayed on the CI repository: https://github.com/konveyor/ci/blob/main/README.md

Maybe better to create another file.

@aufi
Copy link
Member Author

aufi commented Sep 30, 2024

Thanks for the PR @aufi. IIUC it will affect the badge status displayed on the CI repository: https://github.com/konveyor/ci/blob/main/README.md

Maybe better to create another file.

Thanks for review @mguetta1, you're right, updated.

Signed-off-by: Marek Aufart <maufart@redhat.com>
Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aufi aufi merged commit 5297c7a into konveyor:main Oct 1, 2024
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
* Trigger on pull_request workflows on all branches

There are TIER 0..2 on pull request workflows that should check the PR
with CI. These workflows were targeted only to `main` branch that lead
to not being executed on release-* branches. Updated to trigger on all
branches.

Fixes: #173

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Add separate workflows for release branches

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Merge release branches workflows

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
* Trigger on pull_request workflows on all branches

There are TIER 0..2 on pull request workflows that should check the PR
with CI. These workflows were targeted only to `main` branch that lead
to not being executed on release-* branches. Updated to trigger on all
branches.

Fixes: #173

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Add separate workflows for release branches

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Merge release branches workflows

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
* Trigger on pull_request workflows on all branches

There are TIER 0..2 on pull request workflows that should check the PR
with CI. These workflows were targeted only to `main` branch that lead
to not being executed on release-* branches. Updated to trigger on all
branches.

Fixes: #173

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Add separate workflows for release branches

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Merge release branches workflows

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. cherry-pick/release-0.4 This PR should be cherry-picked to release-0.4 branch. cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run TIER0 on pull request with branch target release-0.3, release-0.5
2 participants