Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Carbon.PagedList validation error #127

Merged
merged 6 commits into from
Mar 25, 2024
Merged

fix: Carbon.PagedList validation error #127

merged 6 commits into from
Mar 25, 2024

Conversation

osman-koc
Copy link
Member

@osman-koc osman-koc commented Mar 25, 2024 •
edited
Loading

  • The pageSize and pageNumber validations have been deleted from the constructor method in the PagedList and BasePagedList classes in the Carbon.PagedList package.
  • Updated version for packages using the Carbon.PagedList package.
  • Removed unit test methods about pageSize and pageNumber count.

@anil-eladag anil-eladag merged commit f531bb0 into master Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anil-eladag anil-eladag anil-eladag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osman-koc @anil-eladag