Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Istio inject label #8205

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

pierDipi
Copy link
Member

Ref: #8204

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2024
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.57%. Comparing base (641cbb7) to head (a6a4097).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ciler/apiserversource/resources/receive_adapter.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8205      +/-   ##
==========================================
- Coverage   66.57%   66.57%   -0.01%     
==========================================
  Files         371      371              
  Lines       18271    18281      +10     
==========================================
+ Hits        12164    12170       +6     
- Misses       5323     5325       +2     
- Partials      784      786       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/test unit-tests

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

knative-prow bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e7fca76 into knative:main Sep 26, 2024
34 of 36 checks passed
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 27, 2024
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants