Merge pull request #80 from kiwilan/develop

v2.5.13
kiwilan · Jun 16, 2024 · 522ee87 · 522ee87
2 parents 42068d9 + 10b1aa1
commit 522ee87
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 4 deletions.
diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "kiwilan/php-ebook",
     "description": "PHP package to read metadata and extract covers from eBooks, comics and audiobooks.",
-    "version": "2.5.12",
+    "version": "2.5.13",
     "keywords": [
         "php",
         "ebook",

diff --git a/src/Formats/Audio/AudiobookModule.php b/src/Formats/Audio/AudiobookModule.php
@@ -43,7 +43,6 @@ private function create(): self
 
         $series = $audio->getTag('series') ?? $audio->getTag('mvnm');
         $series_part = $audio->getTag('series-part') ?? $audio->getTag('mvin');
-        $series_part = $this->parseTag($series_part);
         $language = $audio->getTag('language') ?? $audio->getTag('lang');
         $narrators = $audio->getComposer();
 
@@ -66,7 +65,7 @@ private function create(): self
             'synopsis' => $this->parseTag($audio->getTag('description_long')),
             'genres' => $genres,
             'series' => $this->parseTag($series),
-            'series_sequence' => $series_part ? EbookUtils::parseNumber($series_part) : null,
+            'series_sequence' => $series_part !== null ? EbookUtils::parseNumber($series_part) : null,
             'language' => $this->parseTag($language),
             'isbn' => $this->parseTag($audio->getTag('isbn')),
             'asin' => $this->parseTag($audio->getTag('asin') ?? $audio->getTag('audible_asin')),

diff --git a/tests/AudiobookTest.php b/tests/AudiobookTest.php
@@ -95,3 +95,9 @@
 
     expect($ebook->getVolume())->toBe(1.1);
 });
+
+it('can parse audiobook with alt volume at zero', function () {
+    $ebook = Ebook::read(AUDIOBOOK_EWILAN_VOLUME_ZERO);
+
+    expect($ebook->getVolume())->toBe(0);
+});
diff --git a/tests/MetaTitleTest.php b/tests/MetaTitleTest.php
@@ -100,7 +100,6 @@
     $meta = MetaTitle::fromEbook($ebook);
 
     expect($meta->getSlug())->toBe('assassin-royal-fr-000-prince-batard-robin-hobb-1980-epub');
-    ray($ebook->toArray());
 
     $ebook->setTitle("L'apprenti assassin");
     $ebook->setVolume(50);

diff --git a/tests/Pest.php b/tests/Pest.php
@@ -58,6 +58,7 @@
 define('AUDIOBOOK_PART_2', __DIR__.'/media/audiobook-test-2.mp3');
 define('AUDIOBOOK_CHAPTERS', __DIR__.'/media/audiobook-test.m4b');
 define('AUDIOBOOK_EWILAN_VOLUME', __DIR__.'/media/audiobook-ewilan-volume.m4b');
+define('AUDIOBOOK_EWILAN_VOLUME_ZERO', __DIR__.'/media/audiobook-ewilan-volume-0.m4b');
 
 define('FORMAT_AZW3', __DIR__.'/media/alice-lewis-carroll.azw3');
 define('FORMAT_DOCX', __DIR__.'/media/alice-lewis-carroll.docx');

diff --git a/tests/media/audiobook-ewilan-volume-0.m4b b/tests/media/audiobook-ewilan-volume-0.m4b