Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup init improvements #78

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

teodora-aleksovska
Copy link

This PR includes improvements to enabler setup init command. It now checks whether binaries already exist before downloading them.

After running enabler setup init, i received this output:

teodora@teodora-ThinkPad-T16-Gen-1:~/Project/enabler$ enabler setup init
Bin folder already exists. Continue...
-kubectl already exists at: bin/kubectl
helm already exists at: bin/helm
istioctl already exists at: bin/istioctl
kind already exists at: bin/kind
skaffold already exists at: bin/skaffold

@gocemitevski
Copy link
Member

@teodora-aleksovska please describe what happens is some of the binaries does not exist - the mixed case scenario.

@teodora-aleksovska
Copy link
Author

@gocemitevski after running the enabler setup init command, it will check if the binaries exist in the bin folder. If some of them do not exist, this command will download them.

Before these improvements, the downloading process worked correctly every time after running enabler setup init.

@gocemitevski
Copy link
Member

@teodora-aleksovska OK. Please add all relevant descriptions in the README as well for each command. https://github.com/keitaroinc/enabler?tab=readme-ov-file#commands.

@gocemitevski
Copy link
Member

The changes in the README should also be included in the feature-setup-init-improvements branch.

@teodora-aleksovska
Copy link
Author

@gocemitevski additionally, this pull request includes the required changes in the README file and unit tests.

@gocemitevski gocemitevski merged commit 8572bae into main Apr 9, 2024
2 checks passed
@gocemitevski gocemitevski deleted the feature-setup-init-improvements branch April 9, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants