Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: migration to aqt #293

Merged
merged 1 commit into from
Aug 11, 2023
Merged

feature: migration to aqt #293

merged 1 commit into from
Aug 11, 2023

Conversation

rameauv
Copy link
Contributor

@rameauv rameauv commented Jul 10, 2023 •
edited
Loading

When possible use aqt instead of directly using PyQt.
This will make morphman compatible with anki-qt5 and anki-qt6.

#291
#286

landonepps
landonepps approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@landonepps landonepps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Looks good!

@landonepps landonepps merged commit 680f308 into kaegi:master Aug 11, 2023
3 checks passed
landonepps added a commit that referenced this pull request Aug 13, 2023
@landonepps @rameauv
Use aqt for PyQt5 backwards compatiblity (#293) (#297)
206ff99 
* When possible use aqt instead of directly using PyQt.
* This will make morphman compatible with anki-qt5 and anki-qt6.

Motivation: #291 #286
Co-authored-by: rameauv <valentin.rameau@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landonepps landonepps landonepps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rameauv @landonepps