Token object for verifying and signing tokens #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakinj
force-pushed
the
wrap-token-in-an-object
branch
3 times, most recently
from
554a643
to
33cb206
Compare
anakinj
changed the title
anakinj
force-pushed
the
wrap-token-in-an-object
branch
from
33cb206
to
142fc0c
Compare
anakinj
changed the title
anakinj
force-pushed
the
wrap-token-in-an-object
branch
from
57ac9d3
to
33ddcf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a
::JWT::Tokenobject to represent a token. Can be used for signing or verifying the content.Somewhat addresses #124 and #270 by allowing a token instance be instantiated using a jwt token string.
Latter part of #566 is addressed by dropping the
verify_*parameters and allowing explicit claim validation based on the name of the claim (plus a few custom ones).A separate journey is to support the different type of key finders when verifying/signing the token.
Checklist
Before the PR can be merged be sure the following are checked: