Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the loose base64 decoding. #582

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Dec 30, 2023

Description

I first started by implementing the base64 methods within the gem (#578), but that did not really make sense in the end and there was already a bunch of direct references to the Base64 module.

This PR:

  • Adds a dependency to the base64 gem and makes the dependency handling compatible with future Ruby versions.
  • Warns about base64 payloads with invalid content (RFC 2045). Support for this will be dropped in later versions.

Checklist

Before the PR can be merged be sure the following are checked:

  • There are tests for the fix or feature added/changed
  • A description of the changes and a reference to the PR has been added to CHANGELOG.md. More details in the CONTRIBUTING.md

@anakinj anakinj merged commit 39aa57a into jwt:main Jan 29, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant