Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signature has expired error if payload is a string #555

Merged
merged 4 commits into from
Jul 29, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/jwt/verify.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ def verify_aud
end

def verify_expiration
return unless @payload.include?('exp')
return unless contains_key?(@payload, 'exp')
raise(JWT::ExpiredSignature, 'Signature has expired') if @payload['exp'].to_i <= (Time.now.to_i - exp_leeway)
end

def verify_iat
return unless @payload.include?('iat')
return unless contains_key?(@payload, 'iat')

iat = @payload['iat']
raise(JWT::InvalidIatError, 'Invalid iat') if !iat.is_a?(Numeric) || iat.to_f > Time.now.to_f
Expand Down Expand Up @@ -77,7 +77,7 @@ def verify_jti
end

def verify_not_before
return unless @payload.include?('nbf')
return unless contains_key?(@payload, 'nbf')
raise(JWT::ImmatureSignature, 'Signature nbf has not been reached') if @payload['nbf'].to_i > (Time.now.to_i + nbf_leeway)
end

Expand All @@ -92,7 +92,7 @@ def verify_required_claims
return unless (options_required_claims = @options[:required_claims])

options_required_claims.each do |required_claim|
raise(JWT::MissingRequiredClaim, "Missing required claim #{required_claim}") unless @payload.include?(required_claim)
raise(JWT::MissingRequiredClaim, "Missing required claim #{required_claim}") unless contains_key?(@payload, required_claim)
end
end

Expand All @@ -109,5 +109,9 @@ def exp_leeway
def nbf_leeway
@options[:nbf_leeway] || global_leeway
end

def contains_key?(payload, key)
payload.respond_to?(:key?) && payload.key?(key)
end
end
end