Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix argument order in publish_status #395

Closed
wants to merge 1 commit into from

Conversation

DerThorsten
Copy link
Member

No description provided.

@JohanMabille
Copy link
Member

Can you also set JSON_USE_IMPLICIT_CONVERSIONS to 0 in xeus.hpp? This would catch potential remaining similar issues, and would avod to get hit again in the future.

@DerThorsten
Copy link
Member Author

superseded by #396

@DerThorsten
Copy link
Member Author

JSON_USE_IMPLICIT_CONVERSIONS

Can you also set JSON_USE_IMPLICIT_CONVERSIONS to 0 in xeus.hpp? This would catch potential remaining similar issues, and would avod to get hit again in the future.

this gives a lot of warnings a la:

/Users/thorstenbeier/src/xeus/include/xeus/xeus.hpp:13:9: warning: 'JSON_USE_IMPLICIT_CONVERSIONS' macro redefined [-Wmacro-redefined]
   13 | #define JSON_USE_IMPLICIT_CONVERSIONS 0
      |         ^
/Users/thorstenbeier/micromamba/envs/xeus-wasm-dev/include/nlohmann/detail/macro_scope.hpp:467:13: note: previous definition is here
  467 |     #define JSON_USE_IMPLICIT_CONVERSIONS 1

@JohanMabille
Copy link
Member

Ah, so it should probably be defined befor including nlohmann_json for the first time. Let's fix that in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants