Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify-wasm-kernels #9

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Conversation

DerThorsten
Copy link
Member

@DerThorsten DerThorsten commented Nov 27, 2023

  • also build test kernel for the browser and not only for node
  • install test kernel properly st. we can consume it jupyterlite.
    • added xeus-lite logo which is just the xeus logo itself
    • added kernelspec kernel.json for testkernel
  • deleted typescript code, this will not needed any more

@DerThorsten DerThorsten mentioned this pull request Nov 27, 2023
@DerThorsten DerThorsten marked this pull request as ready for review November 28, 2023 09:00
Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do not hesitate to squash the commits when you clean the CMakeLists.txt.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you delete the ts files, you can also remove the line

set(XEUS_LITE_TS_INSTALL_DIR "${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME}" CACHE STRING "install path for typescript files")

from this CMakeLists.txt.

(I did not find how to comment on a line that is not in the diff).

@DerThorsten DerThorsten merged commit 395431c into jupyter-xeus:main Nov 29, 2023
2 checks passed
@DerThorsten DerThorsten deleted the unify_wasm_kernels branch November 29, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants