remove subtotal row if it exists #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I use the Amazon Order History Reporter plugin it creates a final row in the output CSV that looks something like this: ``` "=SUBTOTAL(103, A2:A11) & "" items""",,,,,"=SUBTOTAL(109,F2:F11)","=SUBTOTAL(109,G2:G11)","=SUBTOTAL(109,H2:H11)","=SUBTOTAL(109,I2:I11)","=SUBTOTAL(109,J2:J11)","=SUBTOTAL(109,K2:K11)",, ``` I run this tool just infrequently enough that I always forget I need to remove this line. This change checks for its existence and removes it from the dataframe of amazon order information
|
Nice - thank you! I haven't run into this before - but I will get this teested and pushed |
|
I tested this using pipx run \
--spec git+https://github.com/jpjpjp/lunchable-primelunch@tolerate_subtotal_row \
lunchable-primelunch \
-f ~/Downloads/amazon_order_history.csv \
-w 28 |
github-actions bot
added a commit
that referenced
this pull request
Apr 22, 2024
# [v1.0.2](v1.0.1...v1.0.2) (2024-04-22) ## 🐛 Bug Fixes - [`4a44637`](4a44637) remove subtotal row if it exists (Issues: [`#4`](#4)) [skip ci]
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Shoot - there was a failure on the release to PyPI. I'll get this sorted |
|
Alright, everything is resolved now and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use the Amazon Order History Reporter plugin it creates a final row in the output CSV that looks something like this:
I run this tool just infrequently enough that I always forget I need to remove this line.
This change checks for its existence and removes it from the dataframe of amazon order information