Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of Dockerfile #56

Open
wants to merge 1 commit into
base: 2.6.0.Final
Choose a base branch
from

Conversation

pmuir
Copy link

@pmuir pmuir commented Nov 9, 2014

No description provided.

@pmuir
Copy link
Author

pmuir commented Nov 9, 2014

DO NOT MERGE

@ipbabble
Copy link

Would it be beneficial to combine some of the "RUN" cmds into a script that is added to the image? That way you can have one RUN layer and not so many.

@pmuir
Copy link
Author

pmuir commented Dec 10, 2014

@ipbabble what is best practice with Docker? :-)

@ipbabble
Copy link

I don't think it's fully decided yet. One could and would argue that having it in the Dockerfile is better because of transparency. i.e. the way you do it is correct. But because of the layering and the inability to squash layers then it becomes way too many layers for your image. You might also wish to pull some stuff out of the script if you think that you don't want certain steps run over and over again on build.

So maybe I've answered my own question ;-) i.e. it's perhaps not beneficial during dev. but beneficial when you've figured out what layers you are ok with as you move out of dev.

@pmuir
Copy link
Author

pmuir commented Dec 10, 2014

That's probably a great point to add to the tutorial, when we document this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants