Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve flake8 errors #503

Merged
merged 1 commit into from
May 6, 2024
Merged

Resolve flake8 errors #503

merged 1 commit into from
May 6, 2024

Conversation

dragon-dxw
Copy link
Contributor

Resolve flake8 errors

https://stackoverflow.com/questions/57074300/what-is-the-recommended-way-to-break-a-long-if-statement-w504-line-break-after
suggests the recommended approach to breaking long binary statements
is before the operator; we add an exclusion for that, and this
causes an eruption of line-length warnings. We suppress those too.

noqa: F401 is used to square the circle of mypy needing those
imports defined, but flake8 not seeing that they're necessary.

https://stackoverflow.com/questions/57074300/what-is-the-recommended-way-to-break-a-long-if-statement-w504-line-break-after
suggests the recommended approach to breaking long binary statements
is before the operator; we add an exclusion for that, and this
causes an eruption of line-length warnings. We suppress those too.

noqa: F401 is used to square the circle of mypy needing those
imports defined, but flake8 not seeing that they're necessary.
@clintonb clintonb merged commit e63a13f into master May 6, 2024
9 checks passed
@clintonb clintonb deleted the fix-flake8-linting branch May 6, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants