Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Set up pre-commit hooks and fix quality nits #308

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

giovannicimolin
Copy link
Contributor

@giovannicimolin giovannicimolin commented Aug 15, 2023

This PR implements:

  • A pre-commit hook that runs isort and flake8
  • Code coverage reports and codecov WIP

@giovannicimolin
Copy link
Contributor Author

Relates to #304.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@efcfdcb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b55402e differs from pull request most recent head 5b936a7. Consider uploading reports for the commit 5b936a7 to get more accurate results

@@            Coverage Diff             @@
##             develop     #308   +/-   ##
==========================================
  Coverage           ?   90.30%           
==========================================
  Files              ?        9           
  Lines              ?      227           
  Branches           ?       35           
==========================================
  Hits               ?      205           
  Misses             ?       19           
  Partials           ?        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@giovannicimolin
Copy link
Contributor Author

It worked! Still needs some improvements. I'll do them on a follow-up ticket. :)

@giovannicimolin giovannicimolin force-pushed the giovannicimolin/more-jazzband-setup branch from b55402e to 5b936a7 Compare August 15, 2023 18:29
@giovannicimolin giovannicimolin changed the title test: Set up pre-commit hooks and fix quality nits WIP test: Set up pre-commit hooks and fix quality nits Aug 15, 2023
@giovannicimolin giovannicimolin merged commit f0261b2 into develop Aug 15, 2023
12 checks passed
@giovannicimolin giovannicimolin deleted the giovannicimolin/more-jazzband-setup branch August 15, 2023 18:31
dontexit pushed a commit to dontexit/django-rest-knox that referenced this pull request Jan 24, 2024
…zzband-setup

test: Set up pre-commit hooks and fix quality nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant