Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add 'hset, hdel' interfaces #618

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

moonseoklee
Copy link

The interface corresponding to hset, hdel of redis-py has been created.
issue #373

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #618 (b6115c2) into master (38e630f) will decrease coverage by 0.1%.
The diff coverage is 83.1%.

@@           Coverage Diff            @@
##           master    #618     +/-   ##
========================================
- Coverage    83.3%   83.3%   -0.0%     
========================================
  Files          21      21             
  Lines        1043    1102     +59     
========================================
+ Hits          868     917     +49     
- Misses        175     185     +10     
Flag Coverage Δ
tests 83.3% <83.1%> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
django_redis/client/default.py 87.2% <71.5%> (-1.6%) ⬇️
django_redis/cache.py 99.3% <100.0%> (+0.1%) ⬆️
django_redis/client/sharded.py 93.3% <100.0%> (+0.6%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@WisdomPill WisdomPill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are the tests?

without tests we can't merge anything

@moonseoklee
Copy link
Author

I wrote tests

@moonseoklee moonseoklee reopened this Sep 13, 2022
@YashKumarVerma
Copy link

@moonseoklee are you looking for help to close this one?

@moonseoklee
Copy link
Author

@moonseoklee are you looking for help to close this one?
What more do I need to do to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants