Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore backward compatibility for Attribute creation with invalid slugs #639

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Sep 2, 2024

This MR addresses a backward compatibility issue introduced by a recent change in the Attribute model's validation process.

Key changes:

  • Replace ValidationError with a warning when creating Attributes with invalid slugs
  • Update the corresponding test to check for UserWarning instead of ValidationError
  • This change allows existing code to continue functioning while still alerting users to potential issues with invalid slugs.

Replace ValidationError with a warning when creating Attributes with invalid slugs. This change allows existing code to continue functioning while alerting users to potential issues.
@Dresdn Dresdn merged commit 8f18d5e into jazzband:master Sep 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant