Restructure event model code (Sourcery refactored) #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-140
to
+142
| for i, recipe in enumerate(daily_recipes): | ||
| if recipe.is_shopping: | ||
| shopping_indexes.append(i) | ||
|
|
||
| shopping_indexes.extend( | ||
| i for i, recipe in enumerate(daily_recipes) if recipe.is_shopping | ||
| ) |
There was a problem hiding this comment.
Function Event.daily_recipes_split_by_shopping refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
| return sum([t.count for t in self.event_portion_types]) | ||
| return sum(t.count for t in self.event_portion_types) |
There was a problem hiding this comment.
Function Attendable.people_with_any_portion_type_count refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
Comment on lines
53
to
56
| relative_portion_count = 0 | ||
|
|
||
| # count portions of attendees with their portion size | ||
| for attendee in self.attendees: | ||
| relative_portion_count += getattr(attendee.portion_type, "size", 1) | ||
|
|
||
| relative_portion_count = sum( | ||
| getattr(attendee.portion_type, "size", 1) | ||
| for attendee in self.attendees | ||
| ) |
There was a problem hiding this comment.
Function Attendable.relative_portion_count refactored with the following changes:
- Convert for loop into call to sum() (
sum-comprehension)
This removes the following comments ( why? ):
# count portions of attendees with their portion size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #503 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
restructure-event-model-codebranch, then run:Help us improve this pull request!